Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add markDef.tooltip for interactive check #9237

Merged
merged 5 commits into from
Jan 30, 2024

Conversation

ChiaLingWeng
Copy link
Contributor

close #9190

For the original fail case, I found that adding tooltip in the encoding field can solve the issue.
My assumption is the interactiveFlag missed to check markDef.tooltip field, and thus add it in this PR

"encoding": {
        "x": {
          "field": "date",
          "type": "temporal",
          "scale": {"domain": {"param": "brush"}},
          "axis": {"title": ""}
        },
        "y": {"field": "price", "type": "quantitative"},
        "tooltip": [
          {"field": "price", "type": "quantitative"},
          {"field": "date", "type": "temporal"}
        ]
      }

return parentCount
? {
interactive: unitCount > 0 || model.mark === 'geoshape' || !!model.encoding.tooltip
}
: null;

@ChiaLingWeng ChiaLingWeng requested a review from a team as a code owner January 30, 2024 07:04
@domoritz
Copy link
Member

Thank you (for this and the other PRs). You could ask to become a maintainer if you'd like. https://github.com/vega/.github?tab=readme-ov-file#adding-maintainers

@domoritz domoritz merged commit 3891832 into vega:main Jan 30, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Interactive Incorrectly Set to False
2 participants