Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: duplicate sorting in stack #9213

Merged
merged 3 commits into from
Dec 21, 2023
Merged

Conversation

ChiaLingWeng
Copy link
Contributor

try to close #8033,

avoid duplicate field by

          if (!s.field.includes(field)) {
            s.field.push(field);
            s.order.push(sortOrder);
          }

@ChiaLingWeng ChiaLingWeng requested a review from a team as a code owner December 21, 2023 07:49
@domoritz
Copy link
Member

Awesome. Thank you @ChiaLingWeng!

@domoritz domoritz merged commit 3e35dc2 into vega:main Dec 21, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stacks have unnecessary sorting
2 participants