Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mark sequential scales as deprecated #9212

Merged
merged 5 commits into from
Jan 21, 2024

Conversation

ChiaLingWeng
Copy link
Contributor

close #9017

Update in the continuous scale section,
let me know if need to add some warning in the script.
image

@ChiaLingWeng ChiaLingWeng requested a review from a team as a code owner December 21, 2023 01:04
@ChiaLingWeng ChiaLingWeng changed the title doc: mark sequential scales as deprecated docs: mark sequential scales as deprecated Dec 21, 2023
Copy link
Member

@domoritz domoritz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull request. I'd say that since we don't document the sequential scale anywhere in the Vega-Lite docs, we could instead just add a warning if someone uses a sequential scale so that we can delete the types in 6.x.

We don't need to add a note to the docs.

@ChiaLingWeng ChiaLingWeng changed the title docs: mark sequential scales as deprecated fix: mark sequential scales as deprecated Jan 19, 2024
Copy link
Member

@domoritz domoritz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@domoritz domoritz merged commit 93a44db into vega:main Jan 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate sequential scales
2 participants