Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stacks have unnecessary sorting #8033

Closed
domoritz opened this issue Mar 9, 2022 · 0 comments · Fixed by #9213
Closed

Stacks have unnecessary sorting #8033

domoritz opened this issue Mar 9, 2022 · 0 comments · Fixed by #9213
Labels
Bug 🐛 Help Wanted Good tasks for contributors (try https://github.com/vega/vega-lite/issues/1486 first)

Comments

@domoritz
Copy link
Member

domoritz commented Mar 9, 2022

In https://vega.github.io/editor/#/examples/vega-lite/layer_arc_label, we have

Screen Shot 2022-03-09 at 10 47 07

We could simplify this sorting by only sorting by one field.
@domoritz domoritz added Bug 🐛 Help Wanted Good tasks for contributors (try https://github.com/vega/vega-lite/issues/1486 first) labels Mar 9, 2022
@ChiaLingWeng ChiaLingWeng mentioned this issue Dec 21, 2023
Merged
domoritz pushed a commit that referenced this issue Dec 21, 2023
@ChiaLingWeng
fix: duplicate sorting in stack (#9213)

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
3e35dc2 
try to close #8033,

avoid duplicate field by
```
          if (!s.field.includes(field)) {
            s.field.push(field);
            s.order.push(sortOrder);
          }
```

---------

Co-authored-by: GitHub Actions Bot <vega-actions-bot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug 🐛 Help Wanted Good tasks for contributors (try https://github.com/vega/vega-lite/issues/1486 first)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: duplicate sorting in stack ChiaLingWeng/vega-lite
1 participant
@domoritz