Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PrometheusRemoteWriteAuth / http::Auth refactor ? #15121

Open
neuronull opened this issue Nov 4, 2022 · 1 comment
Open

PrometheusRemoteWriteAuth / http::Auth refactor ? #15121

neuronull opened this issue Nov 4, 2022 · 1 comment
Labels
domain: config Anything related to configuring Vector type: tech debt A code change that does not add user value.

Comments

@neuronull
Copy link
Contributor

The prometheus_remote_write auth config currently is copying the basic and bearer options from http::Auth.

We should refactor that so the two don't risk getting out of sync.

This isn't straight forward so far, because serde doesn't appear to be able to flatten enums.

https://github.com/vectordotdev/vector/pull/15112/files#r1014473268
@neuronull neuronull mentioned this issue Nov 4, 2022
Merged
@neuronull
Copy link
Contributor Author

serde-rs/serde#1402

@jszwedko jszwedko added domain: config Anything related to configuring Vector type: tech debt A code change that does not add user value. labels Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
domain: config Anything related to configuring Vector type: tech debt A code change that does not add user value.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jszwedko @neuronull