Create separator component #113
Merged
+178
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
germain-gg
requested review from
dbkr and
weeman1337
and removed request for
a team
germain-gg
force-pushed
the
germain-gg/divider
branch
from
6667a8d to
23cb3d1
Compare
Deploying with
|
| Latest commit: |
78b5ff7
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://6513f04d.compound-web.pages.dev |
| Branch Preview URL: | https://germain-gg-divider.compound-web.pages.dev |
|
Initially, we'll use it just for explicit/standalone Unsure about the benefits of replacing most border decorations (for example, in menus) with a nested instance of a divider component/element, as long as we can apply semantic tokens for those border decorations. |
|
I'll edit the description to reflect that. |
t3chguy
reviewed
Oct 23, 2023
germain-gg
force-pushed
the
germain-gg/divider
branch
from
c9951a1 to
78b5ff7
Compare
robintown
approved these changes
Oct 26, 2023
Comment on lines
+57
to
+59
| // Casting to `RefObject` as everything here should use this type. | ||
| // Functions refs are not something we wish to support and string refs | ||
| // are already unsupported with `forwardRef`. |
There was a problem hiding this comment.
If you're interested, an alternative solution that makes it possible to support function refs would be to create a new const ownRef = useRef(), and then merge it with the forwarded ref
There was a problem hiding this comment.
Hmmm really cool! Didn't know that existed, thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initially, we'll use it just for explicit/standalone
<hr>elements.There are no immediate plans to replace generic borders in components with standalone, nested divider elements.