Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI builds #963

Merged
merged 1 commit into from Jan 26, 2023
Merged

Fix CI builds #963

merged 1 commit into from Jan 26, 2023

Conversation

codealchemy
Copy link
Contributor

@codealchemy codealchemy commented Jan 24, 2023

There has been a Typhoeus spec that has been failing in this project for a few months (most recently in #962), it seems to be tied to the 0.16.0 release of the ethon gem (typhoeus/ethon@v0.15.0...v0.16.0)

Failure

  1) Typhoeus hook when using on_headers callback is expected to yield with args(have attributes {:headers => (include {"Content-Length" => "18"})})
     Failure/Error: it { expect { |b| on_headers(&b) }.to yield_with_args(have_attributes(headers: include('Content-Length' => '18'))) }

       expected given block to yield with arguments, but yielded with unexpected arguments
       expected: [(have attributes {:headers => (include {"Content-Length" => "18"})})]
            got: [#<Typhoeus::Response:0x00007f66226d9ae0 @options={:httpauth_avail=>0, :total_time=>8.2e-05, :starttr...s=>"", :response_body=>"", :debug_info=>#<Ethon::Easy::DebugInfo:0x00007f66226e4a58 @messages=[]>}>]
     # ./spec/lib/vcr/library_hooks/typhoeus_spec.rb:124:in `block (3 levels) in <top (required)>'

@codealchemy codealchemy marked this pull request as ready for review January 24, 2023 20:44
Gemfile Outdated Show resolved Hide resolved
There has been a Typhoeus spec that has been failing in this project for a few months, it seems to be tied to the 0.16.0 release of the `ethon` gem (typhoeus/ethon@v0.15.0...v0.16.0)
@olleolleolle olleolleolle merged commit f353ec2 into vcr:master Jan 26, 2023
@codealchemy codealchemy deleted the patch/fix-CI-builds branch January 26, 2023 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants