Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for on_data with faraday. #823

Merged
merged 1 commit into from Mar 13, 2022

Conversation

zeisler
Copy link
Contributor

@zeisler zeisler commented Jun 15, 2020

Followed style of #656 for Typhoeus.

@zeisler zeisler marked this pull request as draft June 15, 2020 21:12
Followed style of vcr#656 for Typhoeus.
@zeisler zeisler marked this pull request as ready for review June 15, 2020 21:22
Copy link
Member

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, and I compared it to the previous PR, linked in the description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants