Handle query parameters in FileMiddleware redirects #3077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issue Here |
0xTim
requested changes
Oct 5, 2023
0xTim
changed the title
gwynne
reviewed
Oct 5, 2023
Captain-Kirkie
force-pushed
the
bug/query-params
branch
2 times, most recently
from
7d8f5c5
to
479d052
Compare
gwynne
previously requested changes
Oct 7, 2023
fix: redirect to entire path refactor: updating redirection path without string manipulation.
Captain-Kirkie
force-pushed
the
bug/query-params
branch
from
23da1e9
to
da0209b
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3077 +/- ##
==========================================
+ Coverage 76.22% 76.34% +0.12%
==========================================
Files 211 211
Lines 7862 7864 +2
==========================================
+ Hits 5993 6004 +11
+ Misses 1869 1860 -9
|
|
These changes are now available in 4.84.6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correctly handle query parameters when using the redirect functionality in
FileMiddleware.