-
Notifications
You must be signed in to change notification settings - Fork 571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enforce prettier in CI #1804
Enforce prettier in CI #1804
Conversation
.github/workflows/ci.yml
Outdated
@@ -21,6 +21,7 @@ jobs: | |||
node-version: 18 | |||
- run: npm ci | |||
|
|||
- run: ./node_modules/.bin/prettier --check . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use npx prettier . --check
or npm run prettier
with a custom script in package.json instead
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in d3b6f05
4fbe725
to
b8f0a86
Compare
CI should be passing and be ready to merge |
rebased |
Should we add a pre-commit hook as well? https://prettier.io/docs/en/install#git-hooks |
Good idea, done! |
To be merged only after #1801