Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

isEmail: do not allow non-breaking space in user part #2237

Merged
merged 1 commit into from Jun 26, 2023
Merged

isEmail: do not allow non-breaking space in user part #2237

merged 1 commit into from Jun 26, 2023

Conversation

jeremy21212121
Copy link
Contributor

bug(isEmail) Do not allow non-breaking space in user part

Fixes #2218

  • Excluded non-breaking space character from range of acceptable UTF8 characters in the user part of email address

  • Added test cases to confirm fix

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)
  • References provided in PR (where applicable)

@jeremy21212121 jeremy21212121 mentioned this pull request Jun 22, 2023
Closed
profnandaa
profnandaa approved these changes Jun 26, 2023
View reviewed changes
Copy link
Member

@profnandaa profnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix.

@profnandaa profnandaa merged commit 63b1e4d into validatorjs:master Jun 26, 2023
7 checks passed
@profnandaa profnandaa mentioned this pull request Aug 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@profnandaa profnandaa profnandaa approved these changes

@rubiin rubiin rubiin approved these changes

@WikiRik WikiRik WikiRik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Non breaking space bypass email validation
5 participants
@jeremy21212121 @profnandaa @rubiin @WikiRik @mm-jpoole