Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Thailand holidays: add Bridge Public Holiday on Apr 12, 2024 #1690

Merged
merged 1 commit into from
Feb 15, 2024
Merged

Update Thailand holidays: add Bridge Public Holiday on Apr 12, 2024 #1690

merged 1 commit into from
Feb 15, 2024

Conversation

PPsyrius
Copy link
Contributor

Proposed change

The Thai government announced a new Bridge Public Holiday for the Songkran festival on 12th April 2024.
https://www.thaipbs.or.th/news/content/336973

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new python-holidays functionality in general)

Checklist

  • I've followed the contributing guidelines
  • I've run make pre-commit, it didn't generate any changes
  • I've run make test, all tests passed locally

@PPsyrius PPsyrius changed the title Add special holiday for Thailand on 2024-Apr-12 Add special holiday for Thailand on 2024-04-12 Feb 14, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 14, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7896130958

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 7890682123: 0.0%
Covered Lines: 10547
Relevant Lines: 10547
💛 - Coveralls

@PPsyrius PPsyrius changed the title Add special holiday for Thailand on 2024-04-12 Add Thailand's Bridge Public Holiday on Apr 12, 2024 Feb 14, 2024
KJhellico
KJhellico approved these changes Feb 14, 2024
View reviewed changes
Copy link
Collaborator

@KJhellico KJhellico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@arkid15r arkid15r changed the title Add Thailand's Bridge Public Holiday on Apr 12, 2024 Update Thailand holidays: add Bridge Public Holiday on Apr 12, 2024 Feb 15, 2024
arkid15r
arkid15r reviewed Feb 15, 2024
View reviewed changes
Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arkid15r arkid15r added this pull request to the merge queue Feb 15, 2024
Merged via the queue into vacanza:beta with commit a1f8a60 Feb 15, 2024
26 checks passed
@PPsyrius PPsyrius deleted the TH_2024Apr12_special_holiday branch February 16, 2024 04:18
@arkid15r arkid15r mentioned this pull request Feb 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arkid15r arkid15r arkid15r left review comments

@KJhellico KJhellico KJhellico approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@PPsyrius @coveralls @arkid15r @KJhellico