Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Jersey holidays #1664

Merged
merged 13 commits into from
Feb 5, 2024
Merged

Add Jersey holidays #1664

merged 13 commits into from
Feb 5, 2024

Conversation

PPsyrius
Copy link
Contributor

Proposed change

Add Jersey holidays.

Closes #1647.

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new python-holidays functionality in general)

Checklist

  • I've followed the contributing guidelines
  • I've run make pre-commit, it didn't generate any changes
  • I've run make test, all tests passed locally

@coveralls
Copy link

coveralls commented Jan 24, 2024

Pull Request Test Coverage Report for Build 7775399783

  • 0 of 60 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 7760643838: 0.0%
Covered Lines: 10501
Relevant Lines: 10501

💛 - Coveralls

Co-authored-by: ~Jhellico <KJhellico@users.noreply.github.com>
Copy link
Collaborator

@KJhellico KJhellico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's simplify it a bit :)

holidays/countries/jersey.py Outdated Show resolved Hide resolved
holidays/countries/jersey.py Outdated Show resolved Hide resolved
holidays/countries/jersey.py Outdated Show resolved Hide resolved
holidays/countries/jersey.py Outdated Show resolved Hide resolved
Co-authored-by: ~Jhellico <KJhellico@users.noreply.github.com>
@KJhellico KJhellico changed the title Add Jersey Holidays Add Jersey holidays Feb 2, 2024
Copy link

sonarcloud bot commented Feb 4, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

13 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Collaborator

@KJhellico KJhellico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@arkid15r arkid15r added this pull request to the merge queue Feb 5, 2024
Merged via the queue into vacanza:beta with commit 37d9f18 Feb 5, 2024
26 checks passed
@KJhellico KJhellico mentioned this pull request Feb 5, 2024
@PPsyrius PPsyrius deleted the Jersey_holidays branch February 6, 2024 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jersey
4 participants