Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce observed_estimated_label #1633

Merged
merged 6 commits into from Jan 12, 2024

Conversation

arkid15r
Copy link
Collaborator

@arkid15r arkid15r commented Jan 5, 2024

Proposed change

While reviewing #1615 I noticed cases with the extra brackets "(estimated) (observed)" label text inconsistency. This PR is aimed to address the first problem.

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new python-holidays functionality in general)

Checklist

  • I've followed the contributing guidelines
  • I've run make pre-commit, it didn't generate any changes
  • I've run make test, all tests passed locally

@coveralls
Copy link

coveralls commented Jan 5, 2024

Pull Request Test Coverage Report for Build 7465501273

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 7451812408: 0.0%
Covered Lines: 10269
Relevant Lines: 10269

💛 - Coveralls

@arkid15r arkid15r changed the title Merge estimated/observed labels Introduce observed_estimated_label Jan 9, 2024
Copy link
Collaborator

@KJhellico KJhellico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i18n support is something awesome... 🤪

holidays/countries/brunei.py Outdated Show resolved Hide resolved
holidays/locale/en_US/LC_MESSAGES/BN.po Outdated Show resolved Hide resolved
holidays/locale/ms/LC_MESSAGES/BN.po Outdated Show resolved Hide resolved
holidays/locale/th/LC_MESSAGES/BN.po Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Jan 9, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Collaborator Author

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've addressed the comments and added an extra check for estimated/observed_estimated labels

holidays/locale/th/LC_MESSAGES/BN.po Outdated Show resolved Hide resolved
holidays/locale/ms/LC_MESSAGES/BN.po Outdated Show resolved Hide resolved
Copy link
Collaborator

@KJhellico KJhellico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@arkid15r arkid15r added this pull request to the merge queue Jan 12, 2024
Merged via the queue into vacanza:beta with commit ce947df Jan 12, 2024
26 checks passed
@arkid15r arkid15r deleted the merge-estimated-observed-labels branch January 12, 2024 17:46
@arkid15r arkid15r mentioned this pull request Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants