Update US holidays: add CO Cesar Chavez Day

[nwithan8]

Proposed change

• Add Cesar Chavez Day as optional holiday on March 31 in Colorado (same as in Texas), starting in 2001

Source:

• https://denverite.com/2023/12/04/how-cesar-chavez-park-tennyson-street-denver-got-its-name/
• https://www.westword.com/news/denver-traded-for-cesar-chavez-day-but-colorado-legislature-still-honors-columbus-11282490
• https://www.9news.com/article/news/local/city-offices-closed-for-cesar-chavez-day/73-344931490

Type of change

• New country/market holidays support (thank you!)
• Supported country/market holidays update (calendar discrepancy fix, localization)
• Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
• Dependency update (version deprecation/upgrade)
• Bugfix (non-breaking change which fixes an issue)
• Breaking change (a code change causing existing functionality to break)
• New feature (new python-holidays functionality in general)

Checklist

• I've followed the contributing guidelines
• I've run make pre-commit, it didn't generate any changes
• I've run make test, all tests passed locally

[nwithan8]

Quality Gate failed

Failed conditions

B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

^ I'm not in any position to follow that code smell suggestion and make a constant for the holiday. Seems there's multiple places in the same file where the same raw string is used multiple times (e.g. "Lincoln's Birthday"), so clearly this isn't an actual "problem". Hopefully the CI failure doesn't prevent this from being reviewed and adopted.

[coveralls]

Pull Request Test Coverage Report for Build 7429053155

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 100.0%

---

Totals
Change from base Build 7425641631:	0.0%
Covered Lines:	10244
Relevant Lines:	10244

---

💛 - Coveralls

[PPsyrius]

^ I'm not in any position to follow that code smell suggestion and make a constant for the holiday. Seems there's multiple places in the same file where the same raw string is used multiple times (e.g. "Lincoln's Birthday"), so clearly this isn't an actual "problem". Hopefully the CI failure doesn't prevent this from being reviewed and adopted.

Yeah - ignore that one for now; the actual test_cesar_chavez_day(self) in \tests\countries\test_united_states.py could definitely use some update though :)

    def test_cesar_chavez_day(self):
        name = "Cesar Chavez Day"
        self.assertNoHolidayName(name)
        self.assertHolidayName(
            name, self.state_hols["CA"], (f"{year}-03-31" for year in range(1995, 2050))
        )
        self.assertNoHolidayName(name, self.state_hols["CA"], range(1865, 1995))
        obs_dt = (
            "1996-04-01",
            "2002-04-01",
            "2013-04-01",
            "2019-04-01",
        )
        self.assertHolidayName(f"{name} (Observed)", self.state_hols["CA"], obs_dt)
        self.assertNoNonObservedHolidayName(
            f"{name} (Observed)", UnitedStates(subdiv="CA", observed=False), obs_dt
        )
        self.assertHolidayName(
            name, self.state_hols["CO"], (f"{year}-03-31" for year in range(2001, 2050))
        )
        self.assertNoHolidayName(name, self.state_hols["CO"], range(1865, 2001))
        self.assertHolidayName(
            name, self.state_hols["TX"], (f"{year}-03-31" for year in range(2000, 2050))
        )
        self.assertNoHolidayName(name, self.state_hols["TX"], range(1865, 2000))

[sonarcloud]

Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

[arkid15r]

Slick and tidy, thanks for the PR @nwithan8!