Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Thailand holidays #1626

Merged
merged 9 commits into from Jan 11, 2024
Merged

Update Thailand holidays #1626

merged 9 commits into from Jan 11, 2024

Conversation

PPsyrius
Copy link
Contributor

@PPsyrius PPsyrius commented Jan 4, 2024

Proposed change

Update the Thailand calendar for 2024, including two following changes:

  • The date for 2024's Royal Ploughing Ceremony date has now been announced as May 10, 2024, as well as all exact entries from 1960 onwards.
  • The special "Bridge Public Holiday" for Dec 30, 2024 has now been officially gazetted.

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new python-holidays functionality in general)

Checklist

  • I've followed the contributing guidelines
  • I've run make pre-commit, it didn't generate any changes
  • I've run make test, all tests passed locally

@coveralls
Copy link

coveralls commented Jan 4, 2024

Pull Request Test Coverage Report for Build 7486537508

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 7470084685: 0.0%
Covered Lines: 10262
Relevant Lines: 10262

💛 - Coveralls

KJhellico
KJhellico previously approved these changes Jan 4, 2024
Copy link
Collaborator

@KJhellico KJhellico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link

sonarcloud bot commented Jan 11, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🇹🇭 LGTM

holidays/countries/thailand.py Outdated Show resolved Hide resolved
tests/countries/test_thailand.py Show resolved Hide resolved
@arkid15r arkid15r added this pull request to the merge queue Jan 11, 2024
Merged via the queue into vacanza:beta with commit 5cfd3d8 Jan 11, 2024
26 checks passed
@PPsyrius PPsyrius deleted the th_calendar_2024 branch January 12, 2024 03:15
@arkid15r arkid15r mentioned this pull request Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants