Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update China holidays: add observed and substituted holidays in 2001-2024 #1613

Merged
merged 5 commits into from Jan 2, 2024

Conversation

KJhellico
Copy link
Collaborator

@KJhellico KJhellico commented Dec 30, 2023

Proposed change

Resolves #1601

Update China holidays: add observed and substituted holidays in 2001-2024.

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new python-holidays functionality in general)

Checklist

  • I've followed the contributing guidelines
  • I've run make pre-commit, it didn't generate any changes
  • I've run make test, all tests passed locally

@coveralls
Copy link

coveralls commented Dec 30, 2023

Pull Request Test Coverage Report for Build 7389607481

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 7379327874: 0.0%
Covered Lines: 10220
Relevant Lines: 10220

💛 - Coveralls

Copy link
Contributor

@PPsyrius PPsyrius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for improving the Chinese calendar, here are some of the Thai language translations that likely need to be changed here. 👀

holidays/locale/th/LC_MESSAGES/CN.po Outdated Show resolved Hide resolved
holidays/locale/th/LC_MESSAGES/CN.po Outdated Show resolved Hide resolved
@KJhellico
Copy link
Collaborator Author

@PPsyrius, thank you! It's Google Translate 🤷🏻‍♂️

Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

holidays/countries/china.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, does this PR close #1601 ?

@KJhellico KJhellico linked an issue Jan 2, 2024 that may be closed by this pull request
@KJhellico
Copy link
Collaborator Author

Yes, this includes holidays shifting in 2024.

Copy link

sonarcloud bot commented Jan 2, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

16 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@arkid15r arkid15r added this pull request to the merge queue Jan 2, 2024
Merged via the queue into vacanza:beta with commit 781b370 Jan 2, 2024
26 checks passed
@KJhellico KJhellico deleted the upd-china branch January 3, 2024 16:08
@arkid15r arkid15r mentioned this pull request Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update 2024 Chinese holiday
4 participants