Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend HolidayBase::categories to accept a single value #1550

Merged
merged 1 commit into from Nov 11, 2023

Conversation

arkid15r
Copy link
Collaborator

Proposed change

Extend HolidayBase::category to accept a single value

  • Introduce helpers::_normalize_arguments handler
  • Update tests
  • Update examples documentation

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new python-holidays functionality in general)

Checklist

  • I've followed the contributing guidelines
  • I've added references to all holidays information sources used in this PR
  • The code style looks good: make pre-commit command generates no changes
  • All tests pass locally: make test, make tox (we strongly encourage adding tests to your code)

  - Introduce helpers::_normalize_arguments
  - Update tests
  - Update examples documentation
Copy link

sonarcloud bot commented Nov 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.8% 0.8% Duplication

@coveralls
Copy link

Pull Request Test Coverage Report for Build 6828746460

  • 10 of 10 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.978%

Totals Coverage Status
Change from base Build 6828617897: 0.0%
Covered Lines: 10240
Relevant Lines: 10240

💛 - Coveralls

Copy link
Collaborator

@KJhellico KJhellico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's great! Args like categories=(BANK,) didn't look good.

@arkid15r arkid15r added this pull request to the merge queue Nov 11, 2023
Merged via the queue into vacanza:beta with commit 4eed261 Nov 11, 2023
27 checks passed
@arkid15r arkid15r deleted the normalize-args branch November 11, 2023 19:42
@KJhellico KJhellico mentioned this pull request Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants