New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Slovakia holidays #1546
Update Slovakia holidays #1546
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jose1711, thanks for your adjustments! Epiphany name should be definitely corrected. But according to text of the law, it's "sviatok svätého Cyrila a svätého Metoda".
Also need to make changes to tests and l10n files.
True, however in real life this is almost always shortened to "Sviatok svätého Cyrila a Metoda" or even a bit more: "Sviatok sv. Cyrila a Metoda". It is presumed that both were saints thus seeing "Sviatok Cyrila a Metoda" is not uncommon too. |
Yes, I see. But if we have official sources, we try to rely on them. |
Fair enough - will change that. Also please note that the English translation ( |
Fix missing space.
Kudos, SonarCloud Quality Gate passed! |
Pull Request Test Coverage Report for Build 6826030732
💛 - Coveralls |
Thanks for the contribution @jose1711!
We highly appreciate the real users insights and I would totally understand if you found keeping the law name somewhat frustrating.
Is it something you'd like to take care of within this PR? |
👍
No as this is not exactly my area. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merging this PR, thanks for fixing the name!
Fix missing space and improve spelling.