Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Slovakia holidays #1546

Merged
merged 1 commit into from Nov 11, 2023
Merged

Update Slovakia holidays #1546

merged 1 commit into from Nov 11, 2023

Conversation

jose1711
Copy link
Contributor

Fix missing space and improve spelling.

Copy link
Collaborator

@KJhellico KJhellico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jose1711, thanks for your adjustments! Epiphany name should be definitely corrected. But according to text of the law, it's "sviatok svätého Cyrila a svätého Metoda".
Also need to make changes to tests and l10n files.

@jose1711
Copy link
Contributor Author

according to text of the law, it's "sviatok svätého Cyrila a svätého Metoda".

True, however in real life this is almost always shortened to "Sviatok svätého Cyrila a Metoda" or even a bit more: "Sviatok sv. Cyrila a Metoda". It is presumed that both were saints thus seeing "Sviatok Cyrila a Metoda" is not uncommon too.

@KJhellico
Copy link
Collaborator

Yes, I see. But if we have official sources, we try to rely on them.

@jose1711
Copy link
Contributor Author

Yes, I see. But if we have official sources, we try to rely on them.

Fair enough - will change that. Also please note that the English translation (en_US/LC_MESSAGES/SK.po) is currently in a contracted form: "St. Cyril and Methodius Day".

Fix missing space.
Copy link

sonarcloud bot commented Nov 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@coveralls
Copy link

Pull Request Test Coverage Report for Build 6826030732

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.978%

Totals Coverage Status
Change from base Build 6818776720: 0.0%
Covered Lines: 10200
Relevant Lines: 10200

💛 - Coveralls

@arkid15r
Copy link
Collaborator

Thanks for the contribution @jose1711!

Fair enough - will change that.

We highly appreciate the real users insights and I would totally understand if you found keeping the law name somewhat frustrating.

Also please note that the English translation (en_US/LC_MESSAGES/SK.po) is currently in a contracted form: "St. Cyril and Methodius Day".

Is it something you'd like to take care of within this PR?

@jose1711
Copy link
Contributor Author

Thanks for the contribution @jose1711!

Fair enough - will change that.

We highly appreciate the real users insights and I would totally understand if you found keeping the law name somewhat frustrating.

👍

Also please note that the English translation (en_US/LC_MESSAGES/SK.po) is currently in a contracted form: "St. Cyril and Methodius Day".

Is it something you'd like to take care of within this PR?

No as this is not exactly my area.

@KJhellico KJhellico changed the title Update Slovak holidays Update Slovakia holidays Nov 11, 2023
Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging this PR, thanks for fixing the name!

@arkid15r arkid15r added this pull request to the merge queue Nov 11, 2023
Merged via the queue into vacanza:beta with commit 3188346 Nov 11, 2023
27 checks passed
@KJhellico KJhellico mentioned this pull request Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants