Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Japan holidays: add th localization #1545

Merged
merged 2 commits into from
Nov 10, 2023
Merged

Update Japan holidays: add th localization #1545

merged 2 commits into from
Nov 10, 2023

Conversation

PPsyrius
Copy link
Contributor

Proposed change

This PR adds Thai (th) l10n support for Japan.

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new python-holidays functionality in general)

Checklist

  • I've followed the contributing guidelines
  • I've added references to all holidays information sources used in this PR
  • The code style looks good: make pre-commit command generates no changes
  • All tests pass locally: make test, make tox (we strongly encourage adding tests to your code)

@coveralls
Copy link

coveralls commented Nov 10, 2023 •
edited

Pull Request Test Coverage Report for Build 6825307600

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.978%
Totals Coverage Status
Change from base Build 6818776720: 0.0%
Covered Lines: 10200
Relevant Lines: 10200
💛 - Coveralls

@PPsyrius PPsyrius changed the title Add Thai localization for Japan Add Thai localization for Japan holidays Nov 10, 2023
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
No Duplication information No Duplication information

arkid15r
arkid15r approved these changes Nov 10, 2023
View reviewed changes
Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arkid15r arkid15r added this pull request to the merge queue Nov 10, 2023
Merged via the queue into vacanza:beta with commit e754126 Nov 10, 2023
27 checks passed
@PPsyrius PPsyrius deleted the japan_th_l10n_extended branch November 10, 2023 17:38
@arkid15r arkid15r changed the title Add Thai localization for Japan holidays Update Japan holidays: add th localization Nov 10, 2023
@KJhellico KJhellico mentioned this pull request Nov 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KJhellico KJhellico KJhellico left review comments

@arkid15r arkid15r arkid15r approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@PPsyrius @coveralls @arkid15r @KJhellico