-
Notifications
You must be signed in to change notification settings - Fork 442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Tonga holidays #1534
Add Tonga holidays #1534
Conversation
This PR is marked as a draft should |
Pull Request Test Coverage Report for Build 6710875690
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@PPsyrius , that's great! A new and exciting country! Please look at some refactoring suggestions.
Co-Authored-By: ~Jhellico <KJhellico@users.noreply.github.com>
I have some doubts about the exact meaning of Tonga observed holidays. Is it just an extra day off or is the actual celebration being moved (as in Latin America)? Especially in cases of moving to Monday from other working days. Maybe we should use |
I'm rechecking this at the moment, considering the lack of information in general. The gov website dictates that Nov 4, 2023 - the actual date itself, is also an holiday, at least for Tonga's Ministry of Communications for example, though other evidence i.e. Matangi Tonga Online does indeed points towards LatAm implementation for 2021-2022 for the general public. @arkid15r @KJhellico Please let me know which way implementation better aligns with actual situation here 👀 |
Update: I'm going with the Edit: simply picking the non-observed option would've gotten the same effect as what we're looking for in the government calendar, thus not implemented. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM in general, here are my readability/consistency improvement suggestions:
Co-authored-by: Arkadii Yakovets <ark@cho.red>
Co-authored-by: Arkadii Yakovets <ark@cho.red>
Co-authored-by: Arkadii Yakovets <ark@cho.red>
Co-authored-by: Arkadii Yakovets <ark@cho.red>
Co-authored-by: Arkadii Yakovets <ark@cho.red>
Co-authored-by: Arkadii Yakovets <ark@cho.red>
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🇹🇴 LGTM
Proposed change
Add Tonga holidays (
en_US
,to
localization).Closes #1288.
Type of change
Checklist
make pre-commit
command generates no changesmake test
,make tox
(we strongly encourage adding tests to your code)