New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Australia holidays #1531
Conversation
Pull Request Test Coverage Report for Build 6625701209
💛 - Coveralls |
@KJhellico Would it be possible to convert def _add_anzac_day(self, name):
"""
Add Anzac Day (April 25th)
Anzac Day is a national day of remembrance in Australia and New Zealand
that broadly commemorates all Australians and New Zealanders "who
served and died in all wars, conflicts, and peacekeeping operations"
and "the contribution and suffering of all those who have served".
Anzac Day is a public holiday in Australia, New Zealand, and Tonga; as
well as a public holiday in Samoa up until 2008.
https://en.wikipedia.org/wiki/Anzac_Day
"""
return self._add_holiday_apr_25(name) |
@PPsyrius , thank for your suggestion! I remember seeing this holiday in some countries in Oceania. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work getting rid of date/td imports!
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Proposed change
InternationalHolidays
Type of change
Checklist
make pre-commit
command generates no changesmake test
,make tox
(we strongly encourage adding tests to your code)