Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Thailand's Bridge Public Holiday on Dec 29, 2023 #1528

Merged
merged 2 commits into from
Oct 25, 2023

Conversation

PPsyrius
Copy link
Contributor

@PPsyrius PPsyrius commented Oct 24, 2023

Proposed change

This PR adds the newly announced (as of Oct 24, 2023) Bridge Public Holiday for Dec 29, 2023, while removing the original one on Jan 2 (New Year's Eve (in-lieu)) for 2024 - thus creating a de facto 4-days long holidays period for Dec 29, 2023 - Jan 1, 2024.

Note

There's also a similar consideration for adding a Bridge Public Holiday for Dec 30, 2024 too, but that has yet to be confirmed.

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new python-holidays functionality in general)

Checklist

  • I've followed the contributing guidelines
  • I've added references to all holidays information sources used in this PR
  • The code style looks good: make pre-commit command generates no changes
  • All tests pass locally: make test, make tox (we strongly encourage adding tests to your code)

@sonarcloud
Copy link

sonarcloud bot commented Oct 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@coveralls
Copy link

Pull Request Test Coverage Report for Build 6624613432

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.978%

Totals Coverage Status
Change from base Build 6620987603: 0.0%
Covered Lines: 10068
Relevant Lines: 10068

💛 - Coveralls

Copy link
Collaborator

@KJhellico KJhellico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🇹🇭 LGTM

@arkid15r arkid15r added this pull request to the merge queue Oct 25, 2023
Merged via the queue into vacanza:beta with commit 8595eba Oct 25, 2023
27 checks passed
@PPsyrius PPsyrius deleted the thailand_29_dec_2023_special_holidays branch October 25, 2023 03:01
@arkid15r arkid15r mentioned this pull request Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants