Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate the remaining special_holidays to StaticHolidays class #1519

Merged
merged 6 commits into from Oct 20, 2023

Conversation

PPsyrius
Copy link
Contributor

Proposed change

This PR migrates the remaining holidays that use special_holidays and its variants but are not yet migrated to the new StaticHolidays method, as done in #1509 and #1513.

List of affected countries:

  • AO Angola
  • BN Brunei
  • KH Cambodia (already have this, but the method in question was mislabeled as CameroonStaticHolidays)
  • CM Cameroon
  • CN China
  • SZ Eswatini
  • ID Indonesia
  • JP Japan
  • KE Kenya
  • LA Laos
  • SK Slovakia
  • KR South Korea
  • UY Uruguay

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new python-holidays functionality in general)

Checklist

  • I've followed the contributing guidelines
  • I've added references to all holidays information sources used in this PR
  • The code style looks good: make pre-commit command generates no changes
  • All tests pass locally: make test, make tox (we strongly encourage adding tests to your code)

@coveralls
Copy link

coveralls commented Oct 18, 2023

Pull Request Test Coverage Report for Build 6590175977

  • 79 of 79 (100.0%) changed or added relevant lines in 13 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.978%

Totals Coverage Status
Change from base Build 6580894640: 0.0%
Covered Lines: 9987
Relevant Lines: 9987

💛 - Coveralls

Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for refactoring this!

LGTM 👍

holidays/countries/cambodia.py Outdated Show resolved Hide resolved
holidays/countries/laos.py Outdated Show resolved Hide resolved
@arkid15r arkid15r changed the title Migrate the remaining special_holidays to StaticHolidays method Migrate the remaining special_holidays to StaticHolidays class Oct 20, 2023
PPsyrius and others added 2 commits October 20, 2023 23:15
Co-authored-by: Arkadii Yakovets <ark@cho.red>
Co-authored-by: Arkadii Yakovets <ark@cho.red>
@arkid15r arkid15r added this pull request to the merge queue Oct 20, 2023
Merged via the queue into vacanza:beta with commit 2699783 Oct 20, 2023
19 checks passed
@PPsyrius PPsyrius deleted the remaining_static_holidays branch October 20, 2023 17:58
@arkid15r arkid15r mentioned this pull request Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants