Migrate the remaining special_holidays
to StaticHolidays
class
#1519
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
This PR migrates the remaining holidays that use
special_holidays
and its variants but are not yet migrated to the newStaticHolidays
method, as done in #1509 and #1513.List of affected countries:
AO
AngolaBN
BruneiKH
Cambodia (already have this, but the method in question was mislabeled asCameroonStaticHolidays
)CM
CameroonCN
ChinaSZ
EswatiniID
IndonesiaJP
JapanKE
KenyaLA
LaosSK
SlovakiaKR
South KoreaUY
UruguayType of change
Checklist
make pre-commit
command generates no changesmake test
,make tox
(we strongly encourage adding tests to your code)