Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Timor-Leste holidays #1516

Merged
merged 7 commits into from Oct 19, 2023
Merged

Conversation

PPsyrius
Copy link
Contributor

@PPsyrius PPsyrius commented Oct 16, 2023

Proposed change

Add Timor-Leste holidays (en_US, pt_TL, tet localization; GOVERNMENT, PUBLIC, WORKDAY category) from 2006 onwards, with exact Islamic holiday dates from 2011-2023.

Closes #1286.

Note

The only unimplementable holiday instances being the "Day off: Timor Tour" in 2011, which requires per subdiv special holidays support (#1459). This would probably best be its own separate PR in the future once that function is implemented.

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new python-holidays functionality in general)

Checklist

  • I've followed the contributing guidelines
  • I've added references to all holidays information sources used in this PR
  • The code style looks good: make pre-commit command generates no changes
  • All tests pass locally: make test, make tox (we strongly encourage adding tests to your code)

I swear I keep having new PRs created just when we're due for a new release lol
@coveralls
Copy link

Pull Request Test Coverage Report for Build 6536706928

  • 73 of 73 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.977%

Totals Coverage Status
Change from base Build 6536550163: 0.0%
Covered Lines: 9925
Relevant Lines: 9925

💛 - Coveralls

Copy link
Collaborator

@KJhellico KJhellico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR!

I have just a couple of minor suggestions here:

holidays/countries/timor_leste.py Outdated Show resolved Hide resolved
holidays/locale/en_US/LC_MESSAGES/TL.po Outdated Show resolved Hide resolved
holidays/locale/en_US/LC_MESSAGES/TL.po Outdated Show resolved Hide resolved
holidays/locale/en_US/LC_MESSAGES/TL.po Outdated Show resolved Hide resolved
PPsyrius and others added 2 commits October 19, 2023 09:34
Co-Authored-By: Arkadii Yakovets <2201626+arkid15r@users.noreply.github.com>
Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🇹🇱 LGTM

holidays/locale/en_US/LC_MESSAGES/TL.po Outdated Show resolved Hide resolved
@arkid15r arkid15r added this pull request to the merge queue Oct 19, 2023
Merged via the queue into vacanza:beta with commit f4287d3 Oct 19, 2023
22 checks passed
@PPsyrius PPsyrius deleted the timor_leste_holidays branch October 19, 2023 15:48
@arkid15r arkid15r mentioned this pull request Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Timor-Leste holidays
4 participants