Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Tanzania StaticHolidays #1513

Merged
merged 1 commit into from
Oct 13, 2023
Merged

Conversation

PPsyrius
Copy link
Contributor

Proposed change

This PR implements the StaticHolidays method introduced in #1509 for Tanzania (#1505). No other functional changes otherwise.

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new python-holidays functionality in general)

Checklist

  • I've followed the contributing guidelines
  • I've added references to all holidays information sources used in this PR
  • The code style looks good: make pre-commit command generates no changes
  • All tests pass locally: make test, make tox (we strongly encourage adding tests to your code)

@coveralls
Copy link

Pull Request Test Coverage Report for Build 6506630893

  • 9 of 9 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.977%

Totals Coverage Status
Change from base Build 6500833681: 0.0%
Covered Lines: 9804
Relevant Lines: 9804

💛 - Coveralls

Copy link
Collaborator

@KJhellico KJhellico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great consistentual awareness, @PPsyrius !

I missed this during yesterday's merge session. Thank you!

LGTM

@arkid15r arkid15r changed the title Implementing StaticHolidays method for Tanzania Implement Tanzania StaticHolidays Oct 13, 2023
@arkid15r arkid15r added this pull request to the merge queue Oct 13, 2023
Merged via the queue into vacanza:beta with commit 3f8f47b Oct 13, 2023
22 checks passed
@PPsyrius PPsyrius deleted the Tanzania_Static branch October 14, 2023 01:41
@KJhellico KJhellico mentioned this pull request Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants