Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Maldives holidays #1508

Merged
merged 7 commits into from
Oct 16, 2023
Merged

Add Maldives holidays #1508

merged 7 commits into from
Oct 16, 2023

Conversation

kasya
Copy link
Contributor

@kasya kasya commented Oct 9, 2023

Proposed change

Initial support for Maldives holidays.

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new python-holidays functionality in general)

Checklist

  • I've followed the contributing guidelines
  • I've added references to all holidays information sources used in this PR
  • The code style looks good: make pre-commit command generates no changes
  • All tests pass locally: make test, make tox (we strongly encourage adding tests to your code)

@coveralls
Copy link

coveralls commented Oct 9, 2023

Pull Request Test Coverage Report for Build 6502297718

  • 48 of 48 (100.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.977%

Totals Coverage Status
Change from base Build 6500833681: 0.0%
Covered Lines: 9850
Relevant Lines: 9850

💛 - Coveralls

@arkid15r arkid15r changed the title Add maldives holidays Add Maldives holidays Oct 10, 2023
Copy link
Collaborator

@KJhellico KJhellico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kasya, thank you for new country! 👍 Please look at few suggestions.

README.rst Outdated Show resolved Hide resolved
holidays/countries/maldives.py Show resolved Hide resolved
Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's great to see another country support added to the library.
Nicely done, @kasya!

tests/countries/test_maldives.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@KJhellico KJhellico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@arkid15r arkid15r added this pull request to the merge queue Oct 16, 2023
Merged via the queue into vacanza:beta with commit 6fbabfc Oct 16, 2023
22 checks passed
@arkid15r arkid15r deleted the add-maldives-holidays branch October 16, 2023 15:30
@KJhellico KJhellico mentioned this pull request Oct 16, 2023
This was referenced Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants