Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation for holiday categories usage #1506

Merged
merged 5 commits into from
Oct 12, 2023

Conversation

KJhellico
Copy link
Collaborator

Proposed change

Update documentation for holiday categories usage (README and examples).
Closes #1348.

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new python-holidays functionality in general)

Checklist

  • I've followed the contributing guidelines
  • I've added references to all holidays information sources used in this PR
  • The code style looks good: make pre-commit command generates no changes
  • All tests pass locally: make test, make tox (we strongly encourage adding tests to your code)

@coveralls
Copy link

coveralls commented Oct 8, 2023

Pull Request Test Coverage Report for Build 6499798170

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.977%

Totals Coverage Status
Change from base Build 6498788149: 0.0%
Covered Lines: 9802
Relevant Lines: 9802

💛 - Coveralls

Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a great technical debt reduce contribution, I can see more coming this month :)

@arkid15r arkid15r added this pull request to the merge queue Oct 12, 2023
Merged via the queue into vacanza:beta with commit 600ac69 Oct 12, 2023
22 checks passed
@KJhellico KJhellico deleted the upd-docs-categories branch October 12, 2023 21:13
@KJhellico KJhellico mentioned this pull request Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document the holiday categories usage
3 participants