Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ES snapshot #1481

Merged
merged 1 commit into from Sep 28, 2023
Merged

Update ES snapshot #1481

merged 1 commit into from Sep 28, 2023

Conversation

arkid15r
Copy link
Collaborator

Proposed change

Sync snapshot w/ #1476 changes

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new python-holidays functionality in general)

Checklist

  • I've followed the contributing guidelines
  • I've added references to all holidays information sources used in this PR
  • This PR is filed against beta branch of the repository
  • This PR doesn't contain any merge conflicts and has clean commit history
  • The code style looks good: make pre-commit command generates no changes
  • All tests pass locally: make test, make tox (we strongly encourage adding tests to your code)
  • The related documentation has been added/updated (check off the box for free if no updates is required)

@coveralls
Copy link

Pull Request Test Coverage Report for Build 6304479441

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 6268770681: 0.0%
Covered Lines: 9395
Relevant Lines: 9395

💛 - Coveralls

@PPsyrius
Copy link
Contributor

Just for future PRs, is there a way for contributors to update the relevant snapshot(s) by themselves? @arkid15r

@arkid15r
Copy link
Collaborator Author

Just for future PRs, is there a way for contributors to update the relevant snapshot(s) by themselves? @arkid15r

That's a good question. You can update the snapshot by running make snapshot if that's available for you or just scripts/generate_snapshots.py manually.

I'm still hesitant about adding snapshot update requirement as a part of regular contributor PRs. I don't want overcomplicate the process for new (and existing) contributors. I believe it can be done automatically later but in this case reviewers won't be able to see the "footprint" of holiday changes (if any). @KJhellico what's your opinion on this?

@KJhellico
Copy link
Collaborator

I agree that it's not yet practical to make updated snapshots required for PR, because it will be an additional challenge for new participants. So let's consider this as a desirable condition (like 100% tests coverage).

Copy link
Collaborator

@KJhellico KJhellico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@KJhellico KJhellico added this pull request to the merge queue Sep 28, 2023
Merged via the queue into vacanza:beta with commit ec725f6 Sep 28, 2023
22 checks passed
@arkid15r arkid15r mentioned this pull request Oct 2, 2023
@arkid15r arkid15r deleted the update-snapshots branch October 2, 2023 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants