Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update pre commit automatic update workflow #1469

Merged
merged 2 commits into from
Sep 13, 2023
Merged

Update pre commit automatic update workflow #1469

merged 2 commits into from
Sep 13, 2023

Conversation

arkid15r
Copy link
Collaborator

Proposed change

Update pre commit autoumatic update workflow:

  • Add token contents/pull-requests write permissions
  • Run job for main repository only
  • Set delete-branch flag to true

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new python-holidays functionality in general)

Checklist

  • I've followed the contributing guidelines
  • I've added references to all holidays information sources used in this PR
  • This PR is filed against beta branch of the repository
  • This PR doesn't contain any merge conflicts and has clean commit history
  • The code style looks good: make pre-commit command generates no changes
  • All tests pass locally: make test, make tox (we strongly encourage adding tests to your code)
  • The related documentation has been added/updated (check off the box for free if no updates is required)

@arkid15r
Update pre-commit automatic update workflow
e428015 
Add explicit pull request write permission
Configure automatic branch deletion
@arkid15r
Update pre-commit hooks automatic update workflow
bd7fc9e 
  - Add token contents/pull-requests write permissions
  - Run job for main repository only
  - Set `delete-branch` flag to `true`
@coveralls
Copy link

Pull Request Test Coverage Report for Build 6166818508

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 6162607157: 0.0%
Covered Lines: 9230
Relevant Lines: 9230
💛 - Coveralls

@KJhellico KJhellico changed the title Update pre commit autoumatic update workflow Update pre commit automatic update workflow Sep 13, 2023
KJhellico
KJhellico approved these changes Sep 13, 2023
View reviewed changes
Copy link
Collaborator

@KJhellico KJhellico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's try it!

@arkid15r arkid15r added this pull request to the merge queue Sep 13, 2023
Merged via the queue into vacanza:beta with commit 0b40a49 Sep 13, 2023
22 checks passed
@arkid15r arkid15r deleted the update-pre-commit-autoupdate branch September 13, 2023 16:52
@KJhellico KJhellico mentioned this pull request Sep 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KJhellico KJhellico KJhellico approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@arkid15r @coveralls @KJhellico