Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update package configuration: migrate to pyproject.toml #1466

Merged
merged 9 commits into from Sep 22, 2023

Conversation

arkid15r
Copy link
Collaborator

@arkid15r arkid15r commented Sep 11, 2023

Proposed change

Resolves #1465

Migrate to pyproject.toml

Get rid of setup.cfg
Add package tests
Improve repr coverage

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new python-holidays functionality in general)

Checklist

  • I've followed the contributing guidelines
  • I've added references to all holidays information sources used in this PR
  • This PR is filed against beta branch of the repository
  • This PR doesn't contain any merge conflicts and has clean commit history
  • The code style looks good: make pre-commit command generates no changes
  • All tests pass locally: make test, make tox (we strongly encourage adding tests to your code)
  • The related documentation has been added/updated (check off the box for free if no updates is required)

Use `find_namespace:` for `packages` option
@KJhellico
Copy link
Collaborator

With this parameter, builded tarball includes all scripts (previously l10n only), wheel includes docs, scripts and tests (that were not previously included).

@arkid15r arkid15r changed the title Update setup.cfg: use packages=find_namespace: Update package configuration: migrate to pyproject.toml Sep 18, 2023
@arkid15r
Copy link
Collaborator Author

With this parameter, builded tarball includes all scripts (previously l10n only), wheel includes docs, scripts and tests (that were not previously included).

Yeah, that's not what we want. I migrated the configuration to pyproject.toml. I believe it's okay for sdist to have more src stuff included in scripts. The bdist contains required files only.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 6225294800

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 6225280161: 0.0%
Covered Lines: 9221
Relevant Lines: 9221

💛 - Coveralls

Copy link
Collaborator

@KJhellico KJhellico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We need to test basic functionality of the built package. :)

@arkid15r
Copy link
Collaborator Author

LGTM. We need to test basic functionality of the built package. :)

I did some manual testing for my locally built package. That hadn't been enough as the clean env resulting package was different. Some automated testing would work better here. I added #1479

@arkid15r arkid15r added this pull request to the merge queue Sep 22, 2023
Merged via the queue into vacanza:beta with commit ac29789 Sep 22, 2023
22 checks passed
@arkid15r arkid15r deleted the update-package-build branch September 22, 2023 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean up package build log warnings
3 participants