Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate remaining countries to ObservedHolidayBase #1463

Merged
merged 4 commits into from Sep 15, 2023

Conversation

KJhellico
Copy link
Collaborator

Proposed change

Migrate remaining countries to ObservedHolidayBase (Barbados, Bulgaria, Burundi, Hong Kong, Vanuatu).

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new python-holidays functionality in general)

Checklist

  • I've followed the contributing guidelines
  • I've added references to all holidays information sources used in this PR
  • This PR is filed against beta branch of the repository
  • This PR doesn't contain any merge conflicts and has clean commit history
  • The code style looks good: make pre-commit command generates no changes
  • All tests pass locally: make test, make tox (we strongly encourage adding tests to your code)
  • The related documentation has been added/updated (check off the box for free if no updates is required)

Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments to address:

holidays/countries/bulgaria.py Outdated Show resolved Hide resolved
holidays/countries/bulgaria.py Outdated Show resolved Hide resolved
holidays/countries/hongkong.py Outdated Show resolved Hide resolved
holidays/countries/barbados.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

holidays/countries/bulgaria.py Outdated Show resolved Hide resolved
@arkid15r arkid15r added this pull request to the merge queue Sep 15, 2023
Merged via the queue into vacanza:beta with commit df19d58 Sep 15, 2023
22 checks passed
@KJhellico KJhellico deleted the ref-observed branch September 15, 2023 16:14
@KJhellico KJhellico mentioned this pull request Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants