Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update United Kingdom holidays #1454

Merged
merged 1 commit into from
Sep 12, 2023
Merged

Conversation

KJhellico
Copy link
Collaborator

Proposed change

Update United Kingdom holidays:

  • NIR: add observed holiday to "Battle of the Boyne"
  • SCT: add observed holiday to "St. Andrew's Day"
  • SCT: fix New Year holidays observed rule

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new python-holidays functionality in general)

Checklist

  • I've followed the contributing guidelines
  • This PR is filed against beta branch of the repository
  • This PR doesn't contain any merge conflicts and has clean commit history
  • The code style looks good: make pre-commit
  • All tests pass locally: make test, make tox (we strongly encourage adding tests to your code)
  • The related documentation has been added/updated (check off the box for free if no updates is required)

- NIR: add observed holiday to "Battle of the Boyne"
- SCT: add observed holiday to "St. Andrew's Day"
- SCT: fix New Year observed rule
@KJhellico KJhellico changed the title Update United Kingdom holidays: Update United Kingdom holidays Sep 6, 2023
@arkid15r arkid15r added this pull request to the merge queue Sep 12, 2023
Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🇬🇧 LGTM

Merged via the queue into vacanza:beta with commit 7ce0b50 Sep 12, 2023
22 checks passed
@KJhellico KJhellico deleted the upd-united-kingdom branch September 13, 2023 15:05
@KJhellico KJhellico mentioned this pull request Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants