Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update node versions for cI #732

Merged
merged 3 commits into from Sep 8, 2023
Merged

ci: update node versions for cI #732

merged 3 commits into from Sep 8, 2023

Conversation

broofa
Copy link
Member

@broofa broofa commented Sep 7, 2023

No description provided.

@ctavan
Copy link
Member

ctavan commented Sep 8, 2023

I updated the branch protection to expect the 20.x check to pass instead of 12.x

@ctavan ctavan merged commit 462128b into main Sep 8, 2023
12 checks passed
@ctavan ctavan deleted the ci_node_20 branch September 8, 2023 10:31
@ctavan
Copy link
Member

ctavan commented Sep 8, 2023

Uhm, maybe we should add back the 12.x test? Otherwise I think it would be technically a breaking change to release a new version, WDYT?

We should also update the README for Node 20.x support…

@broofa
Copy link
Member Author

broofa commented Sep 8, 2023

Uhm, maybe we should add back the 12.x test? Otherwise I think it would be technically a breaking change to release a new version, WDYT?

Hmm... good point. I'll add 12.x back in.

[Breadcrumb: link to the debate on whether this sort of thing constitutes a breaking change.]

That said, our node support policy is "supported node releases + 1 prior version", right? So with 16.x slated for premature end-of-life on Monday, we should be able to drop support for 12 & 14 at our leisure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants