Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: adapt bundlewatch config to new main branch name #705

Merged
merged 2 commits into from Mar 23, 2023
Merged

chore: adapt bundlewatch config to new main branch name #705

merged 2 commits into from Mar 23, 2023

Conversation

ctavan
Copy link
Member

@ctavan ctavan commented Mar 23, 2023

No description provided.

@ctavan ctavan requested review from LinusU and broofa March 23, 2023 09:36
broofa
broofa approved these changes Mar 23, 2023
View reviewed changes
Copy link
Member

@broofa broofa left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this not working previously? (Sorry, haven't been paying that close attention to this side of things, obviously. 😳 )

@ctavan ctavan merged commit 6eef540 into main Mar 23, 2023
11 checks passed
@ctavan ctavan deleted the fix-bundlewatch branch March 23, 2023 20:14
@ctavan
Copy link
Member Author

ctavan commented Mar 23, 2023

I think it was still comparing the bundlesize against the last known values from the former master branch but not recording new values when running on main (after a PR merge) because main was not in the trackedBranches…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@broofa broofa broofa approved these changes

@LinusU LinusU Awaiting requested review from LinusU

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ctavan @broofa