fix: use valid query parameters for postgres (#4515)

ehsundar · web-flow · commit c0643ff6fa03 · 2025-03-15T12:59:00.000+08:00
diff --git a/store/db/postgres/memo_filter.go b/store/db/postgres/memo_filter.go
@@ -130,11 +130,8 @@ func (d *DB) ConvertExprToSQL(ctx *filter.ConvertContext, expr *exprv1.Expr) err
 					return errors.New("invalid int value")
 				}
 
-				var factor string
-				if identifier == "creator_id" {
-					factor = "memo.creator_id"
-				}
-				if _, err := ctx.Buffer.WriteString(fmt.Sprintf("%s %s ?", factor, operator)); err != nil {
+				factor := "memo.creator_id"
+				if _, err := ctx.Buffer.WriteString(fmt.Sprintf("%s %s %s", factor, operator, placeholder(len(ctx.Args)+ctx.ArgsOffset+1))); err != nil {
 					return err
 				}
 				ctx.Args = append(ctx.Args, valueInt)

Original file line number	Diff line number	Diff line change
`@@ -130,11 +130,8 @@ func (d DB) ConvertExprToSQL(ctx filter.ConvertContext, expr *exprv1.Expr) err`
`130`	`130`	`return errors.New("invalid int value")`
`131`	`131`	`}`
`132`	`132`
`133`		`- var factor string`
`134`		`- if identifier == "creator_id" {`
`135`		`- factor = "memo.creator_id"`
`136`		`- }`
`137`		`- if _, err := ctx.Buffer.WriteString(fmt.Sprintf("%s %s ?", factor, operator)); err != nil {`
	`133`	`+ factor := "memo.creator_id"`
	`134`	`+ if _, err := ctx.Buffer.WriteString(fmt.Sprintf("%s %s %s", factor, operator, placeholder(len(ctx.Args)+ctx.ArgsOffset+1))); err != nil {`
`138`	`135`	`return err`
`139`	`136`	`}`
`140`	`137`	`ctx.Args = append(ctx.Args, valueInt)`