Stop casting request headers to HTTPHeaderDict #3344
Merged
+3
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While this was done to fix a mypy error, we did not notice the consequences: * This breaks boto3 that subclasses HTTPConnection because HTTPHeaderDict does not support bytes values yet. * When proxying, headers are still a dictionary by default. We can decide to reintroduce a forced conversion to HTTPHeaderDict in urllib3 3.0 if the above issues are fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While this was done to fix a mypy error, we did not notice the consequences:
We can decide to reintroduce a forced conversion to HTTPHeaderDict in urllib3 if the above issues are fixed.
Closes #3343, partly reverts #3134