Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure no remote connections during testing #3328

Merged
merged 3 commits into from Feb 8, 2024

Conversation

miketheman
Copy link
Contributor

As a way to prevent the test suite from making remote calls to anywhere unexpected, use the pytest-socket plugin to disable any calls to hosts other than localhost.

As a way to prevent the test suite from making remote calls to anywhere
unexpected, use the `pytest-socket` plugin to disable any calls to
hosts other than localhost.

Signed-off-by: Mike Fiedler <miketheman@gmail.com>
@miketheman
Copy link
Contributor Author

As this is part of the test infra, I think it could "Skip changelog".

@sethmlarson sethmlarson added the Skip Changelog Pull requests that don't require a changelog entry label Jan 29, 2024
Copy link
Member

@sethmlarson sethmlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Mike!

@illia-v illia-v merged commit 25155d7 into urllib3:main Feb 8, 2024
35 of 36 checks passed
@miketheman miketheman deleted the miketheman/disable-socket branch February 8, 2024 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog Pull requests that don't require a changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants