Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added ca cert data key support in ssl proxy content #3150

Merged
merged 12 commits into from
Nov 3, 2023
Merged

Added ca cert data key support in ssl proxy content #3150

merged 12 commits into from
Nov 3, 2023

Conversation

ravi-kale
Copy link
Contributor

@ravi-kale ravi-kale commented Oct 8, 2023 •
edited by illia-v

Fixes #3065

@ravi-kale ravi-kale marked this pull request as ready for review October 8, 2023 16:24
illia-v
illia-v requested changes Oct 28, 2023
View reviewed changes
Copy link
Member

@illia-v illia-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix, please check my comments

test/with_dummyserver/test_proxy_poolmanager.py Outdated Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
changelog/3065.bugfix.rst Outdated Show resolved Hide resolved
@illia-v illia-v force-pushed the ravi-added-ca-cert-data-key-support-in-ssl-proxy-content branch from e06bb38 to d20f1de Compare November 3, 2023 18:11
@illia-v illia-v merged commit ff764a0 into urllib3:main Nov 3, 2023
24 of 33 checks passed
@illia-v
Copy link
Member

illia-v commented Nov 3, 2023

Thanks @ravi-kale!
#3065 is covered by a $100 bounty, please submit an expense to Open Collective if you’re able to receive funds for working on OSS

@ravi-kale
Copy link
Contributor Author

That's great, Thank You @illia-v

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@illia-v illia-v illia-v approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot pass ssl kwarg cert_data in proxy context
2 participants
@ravi-kale @illia-v