Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a name of an attribute in docs #3125

Merged
merged 1 commit into from Sep 14, 2023
Merged

Fix a name of an attribute in docs #3125

merged 1 commit into from Sep 14, 2023

Conversation

illia-v
Copy link
Member

@illia-v illia-v commented Sep 13, 2023

Docs suggested using conn.is_proxy_verified to check whether TLS connection to a proxy origin is verified, but the actual attribute name is proxy_is_verified.

@illia-v illia-v added the Skip Changelog Pull requests that don't require a changelog entry label Sep 13, 2023
pquentin
pquentin approved these changes Sep 14, 2023
View reviewed changes
Copy link
Member

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM.

@illia-v illia-v merged commit a3e94f2 into urllib3:main Sep 14, 2023
33 of 37 checks passed
@illia-v illia-v deleted the doct-nonexistent-attr branch September 14, 2023 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pquentin pquentin pquentin approved these changes

Assignees
No one assigned
Labels
Skip Changelog Pull requests that don't require a changelog entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@illia-v @pquentin