Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README #3006

Merged
merged 1 commit into from
May 2, 2023
Merged

Update README #3006

merged 1 commit into from
May 2, 2023

Conversation

franekmagiera
Copy link
Member

@franekmagiera franekmagiera commented May 1, 2023 •
edited

Since version 2.0 a top level request method can be used for HTTP calls.

EDIT: Now that I think about it, maybe it would be better if the example in the README would be version agnostic - feel free to close it if you feel that way :)

@franekmagiera
Update README
d57d281 
Since version 2.0 a top level request method can be used for HTTP calls.
@franekmagiera franekmagiera added the Skip Changelog Pull requests that don't require a changelog entry label May 1, 2023
pquentin
pquentin approved these changes May 2, 2023
View reviewed changes
Copy link
Member

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, thanks! This is also what we have in our docs. We think most installs will be 2.0 soon and this is the main branch so it's fine to use that in the README.

@pquentin pquentin merged commit 6351614 into urllib3:main May 2, 2023
34 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pquentin pquentin pquentin approved these changes

Assignees
No one assigned
Labels
Skip Changelog Pull requests that don't require a changelog entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@franekmagiera @pquentin