Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: urfave/cli
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v3.0.0-alpha9.10
Choose a base ref
...
head repository: urfave/cli
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v3.0.0-beta1
Choose a head ref
  • 11 commits
  • 2 files changed
  • 1 contributor

Commits on Nov 30, 2024

  1. Use actions/setup-python in publish-docs

    instead of managing a virtualenv directly which hopefully resolves the
    problem with mkdocs not finding its extensions
    meatballhat committed Nov 30, 2024

    Verified

    This commit was signed with the committer’s verified signature.
    Copy the full SHA
    9fa7327 View commit details
  2. TEMPORARY publish docs from this branch

    meatballhat committed Nov 30, 2024
    Copy the full SHA
    499d63d View commit details
  3. Point setup-python workflow step at mkdocs-reqs.txt

    meatballhat committed Nov 30, 2024
    Copy the full SHA
    ee46b97 View commit details
  4. Run mkdocs command directly to see if that's the problem

    meatballhat committed Nov 30, 2024
    Copy the full SHA
    c8d5a9c View commit details
  5. Run everything mkdocs directly

    meatballhat committed Nov 30, 2024
    Copy the full SHA
    8ed6325 View commit details
  6. Bump mkdocs-material and show frozen deps

    meatballhat committed Nov 30, 2024
    Copy the full SHA
    c6c87e4 View commit details
  7. Why is mkdocs so confuse

    meatballhat committed Nov 30, 2024
    Copy the full SHA
    ac4fa16 View commit details
  8. Once more with feeling

    meatballhat committed Nov 30, 2024
    Copy the full SHA
    3a2488a View commit details
  9. Switch back to make targets

    meatballhat committed Nov 30, 2024
    Copy the full SHA
    0b7af7b View commit details
  10. Remove temporary branch and tag condition overrides

    meatballhat committed Nov 30, 2024
    Copy the full SHA
    0498828 View commit details
  11. Merge pull request #2021 from urfave/publish-docs-python-shuffle

    Use actions/setup-python in publish-docs
    meatballhat authored Nov 30, 2024
    Copy the full SHA
    b81e255 View commit details
Showing with 14 additions and 17 deletions.
  1. +13 −15 .github/workflows/publish-docs.yml
  2. +1 −2 mkdocs-reqs.txt
28 changes: 13 additions & 15 deletions .github/workflows/publish-docs.yml
Original file line number Diff line number Diff line change
@@ -34,13 +34,13 @@ jobs:

- run: make gfmrun
env:
FLAGS: --walk docs/v3/
FLAGS: --walk docs/v3/

- run: make diffcheck

publish:
permissions:
contents: write
contents: write
if: startswith(github.ref, 'refs/tags/')
name: publish
needs: [test-docs]
@@ -50,21 +50,19 @@ jobs:
with:
fetch-depth: 0

- name: Create virtual environment
run: |
python -m venv venv
- uses: actions/setup-python@v5
with:
python-version: '3.13'
cache: pip
cache-dependency-path: mkdocs-reqs.txt

- run: |
. venv/bin/activate
make ensure-mkdocs
env:
FLAGS: --upgrade-pip
- name: Ensure mkdocs is available
run: make ensure-mkdocs

- run: make set-mkdocs-remote
- name: Set mkdocs remote
run: make set-mkdocs-remote
env:
MKDOCS_REMOTE_GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

- run: |
. venv/bin/activate
make deploy-mkdocs
- name: Deploy via mkdocs
run: make deploy-mkdocs
3 changes: 1 addition & 2 deletions mkdocs-reqs.txt
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
mkdocs-git-revision-date-localized-plugin~=1.2
mkdocs-material-extensions~=1.3
mkdocs-material~=8.5
mkdocs-material~=9.5
mkdocs~=1.6
pygments~=2.18