Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add strict option for resolver #327

Merged
merged 3 commits into from
May 1, 2024
Merged

feat: add strict option for resolver #327

merged 3 commits into from
May 1, 2024

Conversation

genffy
Copy link
Contributor

@genffy genffy commented Nov 15, 2023

Description

Fix for #326 ,more details see issuecomment-1812853123

Linked Issues

#326

Additional context

Copy link

stackblitz bot commented Nov 15, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@genffy
Copy link
Contributor Author

genffy commented Nov 15, 2023

emmm, the most of changes were effect by those commands

pnpm run lint-fix
pnpm run test # not pass
vitest -u # update snapshot for pass test
pnpm run typecheck

Copy link

socket-security bot commented Dec 25, 2023

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher

🚮 Removed packages: npm/typescript@5.4.5

View full report↗︎

Copy link

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSource
Install scripts npm/@sveltejs/kit@2.5.7
  • Install script: postinstall
  • Source: node postinstall.js
  • orphan: npm/@sveltejs/kit@2.5.7

View full report↗︎

Next steps

What is an install script?

Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts.

Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore npm/@sveltejs/kit@2.5.7

@antfu antfu merged commit ceba771 into unplugin:main May 1, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants