fix(shared-integration): prevent potential data race in flushTask (#3984)

kermanx · web-flow · commit 141cd743e131 · 2024-07-15T14:50:28.000Z
diff --git a/packages/shared-integration/src/context.ts b/packages/shared-integration/src/context.ts
@@ -108,7 +108,8 @@ export function createContext<Config extends UserConfig<any> = UserConfig<any>>(
   async function flushTasks() {
     const _tasks = [...tasks]
     await Promise.all(_tasks)
-    tasks.splice(0, _tasks.length)
+    if (tasks[0] === _tasks[0])
+      tasks.splice(0, _tasks.length)
   }
 
   return {

Original file line number	Diff line number	Diff line change
`@@ -108,7 +108,8 @@ export function createContext<Config extends UserConfig<any> = UserConfig<any>>(`
`108`	`108`	`async function flushTasks() {`
`109`	`109`	`const _tasks = [...tasks]`
`110`	`110`	`await Promise.all(_tasks)`
`111`		`- tasks.splice(0, _tasks.length)`
	`111`	`+ if (tasks[0] === _tasks[0])`
	`112`	`+ tasks.splice(0, _tasks.length)`
`112`	`113`	`}`
`113`	`114`
`114`	`115`	`return {`