Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: properly debounce dom updates #475

Merged
merged 6 commits into from
Feb 3, 2025

Conversation

harlan-zw
Copy link
Collaborator

@harlan-zw harlan-zw commented Feb 3, 2025

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Current debounce logic does not debounce, instead, it just registers the callback once and any calls while the callback is registered are just ignored.

To resolve this we separate out the debounce functionality into a util and have the implementations handle the debounce.

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
Aaronontheweb Aaron Stannard

Verified

This commit was signed with the committer’s verified signature.
Aaronontheweb Aaron Stannard

Verified

This commit was signed with the committer’s verified signature.
Aaronontheweb Aaron Stannard

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@harlan-zw harlan-zw changed the title fix!: property debounce dom updates fix!: properly debounce dom updates Feb 3, 2025

Verified

This commit was signed with the committer’s verified signature.
Aaronontheweb Aaron Stannard

Verified

This commit was signed with the committer’s verified signature.
Aaronontheweb Aaron Stannard
@harlan-zw harlan-zw mentioned this pull request Feb 2, 2025
54 tasks
@harlan-zw harlan-zw merged commit 3141dba into main Feb 3, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant