Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: uppercase windows drive letters #151

Merged
merged 4 commits into from Jan 10, 2024
Merged

fix: uppercase windows drive letters #151

merged 4 commits into from Jan 10, 2024

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

resolves nuxt/nuxt#24621

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

It was possible for a path segment to mismatch (c: !== C:) owing to drive letter case. This normalises it in relative before splitting into segments.

I can update this if #142 merges first.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added the bug Something isn't working label Dec 11, 2023
@danielroe danielroe requested a review from pi0 December 11, 2023 11:20
@danielroe danielroe self-assigned this Dec 11, 2023
@danielroe danielroe requested review from pi0 and removed request for pi0 January 2, 2024 10:22
Copy link

codecov bot commented Jan 2, 2024

Codecov Report

All modified and coverable lines are covered by tests βœ…

Comparison is base (c9029e2) 99.41% compared to head (5a518f2) 99.42%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #151   +/-   ##
=======================================
  Coverage   99.41%   99.42%           
=======================================
  Files           4        4           
  Lines         342      346    +4     
  Branches      105      106    +1     
=======================================
+ Hits          340      344    +4     
  Misses          2        2           

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

src/path.ts Outdated Show resolved Hide resolved
@pi0 pi0 changed the title fix: uppercase drive letters within relative fix: uppercase windows drive letters Jan 10, 2024
@pi0 pi0 merged commit cbd6095 into main Jan 10, 2024
3 checks passed
@pi0 pi0 deleted the fix/relative-drive-letter branch January 10, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generated tsConfig paths are made relative when using lowercase drive letters
2 participants