Skip to content

Commit 7c9d8f9

Browse files
committedSep 25, 2024·
chore: lint with eslint v9
1 parent a8c4564 commit 7c9d8f9

10 files changed

+25
-27
lines changed
 

‎.eslintignore

-3
This file was deleted.

‎.eslintrc

-7
This file was deleted.

‎README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ const handler = (req, res) => {
104104
}
105105

106106
// listener: { url, getURL, server, close, ... }
107-
const listener = await listen(handler, options?)
107+
const listener = await listen(handler, options)
108108
```
109109

110110
## Options

‎eslint.config.mjs

+13
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
import unjs from "eslint-config-unjs";
2+
3+
// https://github.com/unjs/eslint-config
4+
export default unjs({
5+
ignores: [
6+
"src/lib"
7+
],
8+
rules: {
9+
"unicorn/consistent-destructuring": 0,
10+
"@typescript-eslint/no-non-null-assertion": 0,
11+
"unicorn/no-anonymous-default-export": 0,
12+
},
13+
});

‎src/server/_resolver.ts

+3-1
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,9 @@ export async function createResolver() {
2020
const tryResolve = (id: string) => {
2121
try {
2222
return resolve(id);
23-
} catch {}
23+
} catch {
24+
// Ignore errors
25+
}
2426
};
2527

2628
return {

‎src/server/dev.ts

+3-1
Original file line numberDiff line numberDiff line change
@@ -207,7 +207,9 @@ function normalizeErrorStack(error: Error) {
207207
.map((l) => l.replace(cwd, "."))
208208
.filter((l) => !InternalStackRe.test(l))
209209
.join("\n");
210-
} catch {}
210+
} catch {
211+
// Ignore errors
212+
}
211213
return error;
212214
}
213215

‎src/server/watcher.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ export async function listenAndWatch(
1818
options: Partial<ListenOptions & WatchOptions>,
1919
): Promise<Listener> {
2020
const logger = options.logger || consola.withTag("listhen");
21-
let watcher: AsyncSubscription; // eslint-disable-line prefer-const
21+
let watcher: AsyncSubscription;
2222

2323
// Create dev server
2424
const devServer = await createDevServer(entry, {

‎test/cert.test.ts

-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ import { resolve } from "pathe";
44
import { Listener } from "../src";
55
import { TLSCertOptions, _private } from "../src/_cert";
66

7-
// eslint-disable-next-line no-console
87
// console.log = fn()
98

109
function assertDefaultAttributes(attrs: forge.pki.CertificateField[]) {

‎test/index.test.ts

+4-11
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ import type { IncomingMessage, ServerResponse } from "node:http";
33
import { describe, afterEach, test, expect } from "vitest";
44
import { listen, Listener } from "../src";
55

6-
// eslint-disable-next-line no-console
76
// console.log = fn()
87

98
function handle(request: IncomingMessage, response: ServerResponse) {
@@ -43,7 +42,7 @@ describe("listhen", () => {
4342
});
4443
expect(listener.url.startsWith("http://")).toBe(true);
4544
expect(listener.url.endsWith("/foo/bar")).toBe(true);
46-
// eslint-disable-next-line no-console
45+
4746
// expect(console.log).toHaveBeenCalledWith(expect.stringMatching('\n > Local: http://localhost:3000/foo/bar'))
4847
});
4948

@@ -56,9 +55,8 @@ describe("listhen", () => {
5655
test("listen (https - custom)", async () => {
5756
listener = await listen(handle, {
5857
https: {
59-
// eslint-disable-next-line unicorn/prefer-module
6058
key: resolve(__dirname, ".tmp/certs", "key.pem"),
61-
// eslint-disable-next-line unicorn/prefer-module
59+
6260
cert: resolve(__dirname, ".tmp/certs", "cert.pem"),
6361
},
6462
hostname: "localhost",
@@ -69,9 +67,8 @@ describe("listhen", () => {
6967
test("listen (https - custom - with private key passphrase)", async () => {
7068
listener = await listen(handle, {
7169
https: {
72-
// eslint-disable-next-line unicorn/prefer-module
7370
key: resolve(__dirname, ".tmp/certs", "encrypted-key.pem"),
74-
// eslint-disable-next-line unicorn/prefer-module
71+
7572
cert: resolve(__dirname, ".tmp/certs", "cert.pem"),
7673
passphrase: "cert-pw",
7774
},
@@ -87,9 +84,8 @@ describe("listhen", () => {
8784
expect(() =>
8885
listen(handle, {
8986
https: {
90-
// eslint-disable-next-line unicorn/prefer-module
9187
key: resolve(__dirname, ".tmp/certs", "encrypted-key.pem"),
92-
// eslint-disable-next-line unicorn/prefer-module
88+
9389
cert: resolve(__dirname, ".tmp/certs", "cert.pem"),
9490
passphrase: "wrong-pw",
9591
},
@@ -102,7 +98,6 @@ describe("listhen", () => {
10298
test("listen (https - PCKS#12/pfx/p12 - with store passphrase)", async () => {
10399
const listener = await listen(handle, {
104100
https: {
105-
// eslint-disable-next-line unicorn/prefer-module
106101
pfx: resolve(__dirname, ".tmp/certs/keystore.p12"),
107102
passphrase: "store-pw",
108103
},
@@ -115,7 +110,6 @@ describe("listhen", () => {
115110
expect(() =>
116111
listen(handle, {
117112
https: {
118-
// eslint-disable-next-line unicorn/prefer-module
119113
pfx: resolve(__dirname, ".tmp/certs/keystore.p12"),
120114
},
121115
hostname: "localhost",
@@ -129,7 +123,6 @@ describe("listhen", () => {
129123
expect(() =>
130124
listen(handle, {
131125
https: {
132-
// eslint-disable-next-line unicorn/prefer-module
133126
pfx: resolve(__dirname, ".tmp/certs/keystore.p12"),
134127
passphrase: "wrong-pw",
135128
},

‎test/setup.ts

-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@ import { _private } from "../src/_cert";
66

77
export async function setup() {
88
if (!existsSync(resolve("test/.tmp/certs/cert.pem"))) {
9-
// eslint-disable-next-line unicorn/prefer-top-level-await
109
const start = Date.now();
1110
console.log("Generating certificates...");
1211
await generateCert();

0 commit comments

Comments
 (0)
Please sign in to comment.