Skip to content

The new underlining feature from #191 is a breaking change #203

@trevor-vaughan

Description

@trevor-vaughan

Environment

All

Reproduction

logger = require('consola')

myobj = { foo: 'my_content', bar: 'should_not_be_underlined' }
logger.log(myobj)

3.1.0 Output

{ foo: 'my_content', bar: 'should_not_be_underlined' }

3.2.0 Output

{ foo: 'mycontent', bar: 'shouldnotbeunderlined' }

Describe the bug

The console output from 3.2.0 does not match the output from 3.1.0.

Ideally, fancy formatting would be opt-in instead of opt-out at runtime.

Additional context

No response

Logs

No response

Activity

trevor-vaughan

trevor-vaughan commented on Jun 27, 2023

@trevor-vaughan
Author

Ah, I see that I should use consola/basic instead.

trevor-vaughan

trevor-vaughan commented on Jun 27, 2023

@trevor-vaughan
Author

Ah, no, I need to re-open this. I want the fancy formatting in terms of error messages, etc. But I definitely do not want object dumps to be processed as "fancy".

trevor-vaughan

trevor-vaughan commented on Jun 27, 2023

@trevor-vaughan
Author

Hmm...this also causes issues with something as simple as My file names are some_thing.jpg and foo_bar.jpg

I would definitely prefer an opt-in to any delimiter-based options on a per-message basis. Otherwise, any dynamic content could cause a mess on output.

pi0

pi0 commented on Jun 27, 2023

@pi0
Member

Sorry for the regression. Fixing soon

image
trevor-vaughan

trevor-vaughan commented on Jun 27, 2023

@trevor-vaughan
Author

@pi0 No worries, appreciate both the awesome tool and rapid response :-D.

FWIW, I do like the concept that was introduced, I just think that it needs to be selectively opt-in.

pi0

pi0 commented on Jun 27, 2023

@pi0
Member

No worries. Can you please test with latest version? Is it still problematic for you?

trevor-vaughan

trevor-vaughan commented on Jun 27, 2023

@trevor-vaughan
Author

@pi0 Good to go! Appreciate the quick turnaround.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @trevor-vaughan@pi0

        Issue actions

          The new underlining feature from #191 is a breaking change · Issue #203 · unjs/consola