Skip to content

Commit edd1bb9

Browse files
committedApr 10, 2023
refactor: remove global async option
1 parent cabd04f commit edd1bb9

File tree

3 files changed

+4
-27
lines changed

3 files changed

+4
-27
lines changed
 

Diff for: ‎src/consola.ts

+2-19
Original file line numberDiff line numberDiff line change
@@ -247,7 +247,7 @@ export class Consola {
247247

248248
_logFn(defaults: ConsolaLogObject, args: any[], isRaw?: boolean) {
249249
if (((defaults.level as number) || 0) > this.level) {
250-
return this.options.async ? Promise.resolve(false) : false;
250+
return false;
251251
}
252252

253253
// Construct a new log object
@@ -304,11 +304,7 @@ export class Consola {
304304
// Log
305305
if (newLog) {
306306
this._lastLog.object = logObj as ConsolaReporterLogObject;
307-
if (this.options.async) {
308-
return this._logAsync(logObj as ConsolaReporterLogObject);
309-
} else {
310-
this._log(logObj as ConsolaReporterLogObject);
311-
}
307+
this._log(logObj as ConsolaReporterLogObject);
312308
}
313309
};
314310

@@ -350,24 +346,11 @@ export class Consola {
350346
_log(logObj: ConsolaReporterLogObject) {
351347
for (const reporter of this.options.reporters) {
352348
reporter.log(logObj, {
353-
async: false,
354349
stdout: this.stdout,
355350
stderr: this.stderr,
356351
});
357352
}
358353
}
359-
360-
_logAsync(logObj: ConsolaReporterLogObject) {
361-
return Promise.all(
362-
this.options.reporters.map((reporter) =>
363-
reporter.log(logObj, {
364-
async: true,
365-
stdout: this.stdout,
366-
stderr: this.stderr,
367-
})
368-
)
369-
);
370-
}
371354
}
372355

373356
export interface ConsolaInstance extends Consola {

Diff for: ‎src/reporters/basic.ts

+2-6
Original file line numberDiff line numberDiff line change
@@ -57,15 +57,11 @@ export default class BasicReporter {
5757
]);
5858
}
5959

60-
log(logObj: ConsolaReporterLogObject, { async, stdout, stderr }: any = {}) {
60+
log(logObj: ConsolaReporterLogObject, { stdout, stderr }: any = {}) {
6161
const line = this.formatLogObj(logObj, {
6262
width: stdout.columns || 0,
6363
});
6464

65-
return writeStream(
66-
line + "\n",
67-
logObj.level < 2 ? stderr : stdout,
68-
async ? "async" : "default"
69-
);
65+
return writeStream(line + "\n", logObj.level < 2 ? stderr : stdout);
7066
}
7167
}

Diff for: ‎src/types.ts

-2
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,6 @@ export type ConsolaMockFn = (
5454
) => ConsolaMock;
5555

5656
export interface ConsolaReporterArgs {
57-
async: boolean;
5857
stdout: NodeJS.WritableStream;
5958
stderr: NodeJS.WritableStream;
6059
}
@@ -70,7 +69,6 @@ export interface ConsolaOptions {
7069
defaults: ConsolaLogObject;
7170
throttle: number;
7271
throttleMin: number;
73-
async?: boolean;
7472
stdout?: NodeJS.WritableStream;
7573
stderr?: NodeJS.WritableStream;
7674
mockFn?: ConsolaMockFn;

0 commit comments

Comments
 (0)
Please sign in to comment.