Skip to content

Commit bd03098

Browse files
committedMar 28, 2023
refactor: rename global to globalThis
·
v3.4.2v3.0.0-1
1 parent d6a3776 commit bd03098

File tree

2 files changed

+15
-15
lines changed

2 files changed

+15
-15
lines changed
 

‎src/consola.node.ts‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -43,8 +43,8 @@ function createConsola() {
4343
return consola;
4444
}
4545

46-
if (!global.consola) {
47-
global.consola = createConsola();
46+
if (!globalThis.consola) {
47+
globalThis.consola = createConsola();
4848
}
4949

50-
export default global.consola;
50+
export default globalThis.consola;

‎test/assign-reference.test.js‎

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ describe("assignGlobalConsola", () => {
2020
const symbol1 = "my-symbol1";
2121
const consola1 = new TestClass("my-consola1");
2222
consola1.symbol = symbol1;
23-
global.consola = consola1;
23+
globalThis.consola = consola1;
2424
const json1 = JSON.stringify(consola1);
2525

2626
const symbol2 = "my-symbol2";
@@ -31,13 +31,13 @@ describe("assignGlobalConsola", () => {
3131
expect(consola3).not.toBe(consola1);
3232
expect(consola3.symbol).toBe(symbol1);
3333

34-
expect(global.consola).toBe(consola1);
35-
expect(global.consola).not.toBe(consola2);
36-
expect(global.consola).not.toBe(consola3);
34+
expect(globalThis.consola).toBe(consola1);
35+
expect(globalThis.consola).not.toBe(consola2);
36+
expect(globalThis.consola).not.toBe(consola3);
3737

38-
expect(global.consola.symbol).toBe(consola1.symbol);
39-
expect(global.consola.symbol).toBe(consola2.symbol);
40-
expect(global.consola.symbol).not.toBe(consola3.symbol);
38+
expect(globalThis.consola.symbol).toBe(consola1.symbol);
39+
expect(globalThis.consola.symbol).toBe(consola2.symbol);
40+
expect(globalThis.consola.symbol).not.toBe(consola3.symbol);
4141

4242
expect(JSON.stringify(consola1)).toEqual(JSON.stringify(consola2));
4343
expect(JSON.stringify(consola3)).toEqual(json1);
@@ -60,7 +60,7 @@ describe("assignGlobalConsola", () => {
6060

6161
const param1 = "my-consola1";
6262
const consola1 = new TestClass(param1);
63-
global.consola = consola1;
63+
globalThis.consola = consola1;
6464

6565
expect(consola1.fn()).toBe(param1);
6666

@@ -70,13 +70,13 @@ describe("assignGlobalConsola", () => {
7070

7171
expect(consola2.fn()).toBe(param2);
7272
expect(consola3.fn()).toBe(param1);
73-
expect(global.consola.fn()).toBe(param2);
73+
expect(globalThis.consola.fn()).toBe(param2);
7474
});
7575

7676
test("cannot assign different constructor", () => {
7777
class TestClass {}
7878
class TestClass2 {}
79-
global.consola = new TestClass();
79+
globalThis.consola = new TestClass();
8080

8181
expect(() => {
8282
assignGlobalConsola(new TestClass2());
@@ -86,7 +86,7 @@ describe("assignGlobalConsola", () => {
8686
test("can assign inherited constructor to base", () => {
8787
class TestClass {}
8888
class TestClass2 extends TestClass {}
89-
global.consola = new TestClass();
89+
globalThis.consola = new TestClass();
9090

9191
expect(() => {
9292
assignGlobalConsola(new TestClass2());
@@ -97,7 +97,7 @@ describe("assignGlobalConsola", () => {
9797
class TestClass {}
9898
class TestClass2 extends TestClass {}
9999
class TestClass3 extends TestClass2 {}
100-
global.consola = new TestClass3();
100+
globalThis.consola = new TestClass3();
101101

102102
expect(() => {
103103
assignGlobalConsola(new TestClass());

0 commit comments

Comments
 (0)
Please sign in to comment.